Railsdog spree → 0.10.0

Comments and changes to this ticket

• 

  Marcin 'swistak' Raczkowski October 12th, 2009 @ 03:01 PM

  • → Assigned user set to “Marcin 'swistak' Raczkowski”
  • → State changed from “new” to “open”

  Part of functionality for #810
  Large portions of code already in 810 branch, will be separated after code stabilizes

• 

  Roman Smirnov October 12th, 2009 @ 04:06 PM

  Part of functionality for #810

  I don't think so. This issue is about the opportunities to search through any search-library like acts_as_xapian, thinking_sphinx, searchlogic, etc. Simply by default will be used SearchLogic.
  And in extensions for the use of other search-library, will be prescribed in activate method via something like:

      Spree::Config.searcher = Spree::Search::Xapian.new
      #or
      Spree::Config.searcher = Spree::Search::ThinkingSphinx.new
  

  See http://github.com/romul/spree/commits/820-product-search for more info.

• 

  Roman Smirnov October 12th, 2009 @ 04:12 PM

  • → Assigned user cleared.

  P.S. It's my task ;-)

• 

  Marcin 'swistak' Raczkowski October 12th, 2009 @ 04:15 PM

  Right, sorry about that, mass reassigning of tickets to myself, and little friendly fire ;) It'll have to be included in #810 though, could you ping me on jabber so we can cooridinate ?

• 

  Roman Smirnov October 13th, 2009 @ 03:52 AM

  • → Assigned user set to “Roman Smirnov”
• 

  Roman Smirnov October 13th, 2009 @ 10:12 AM

  • → State changed from “open” to “patched”

  See http://github.com/romul/spree/commits/820-product-search

• 

  schof October 13th, 2009 @ 08:29 PM

  I ran into a problem on the product index view.

  You have a nil object when you didn't expect it!
  You might have expected an instance of Array.
  The error occurred while evaluating nil.split
  

  Here's a truncated stack trace

  /Users/schof/open_source/spree/lib/spree/search/base.rb:4:in `get_ids_for'
  /Users/schof/open_source/spree/app/models/product.rb:61
  /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/named_scope.rb:92:in `call'
  /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/named_scope.rb:92:in `named_scope'
  /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/named_scope.rb:172:in `call'
  /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/named_scope.rb:172:in `method_missing'
  /Users/schof/open_source/spree/app/controllers/products_controller.rb:51:in `collection'
  ...
  

  I was able to get this to work when running from the products details page. It looks pretty good in that case.

• 

  Roman Smirnov October 14th, 2009 @ 04:54 AM

  I'm sorry, I was so engrossed in search implementation that had forgotten that params[:keywords] can be blank.

  P.S. Typo fix and little refactoring: http://github.com/romul/spree/commit/261f3713775eb7092b8efa739a9c2e...

• 

  railsdog October 14th, 2009 @ 04:16 PM

  • → State changed from “patched” to “resolved”

  (from [f859b2eea9940825e53c5af16786c0ec208dd8db]) Simple product search with a default SL implementation

  [#820 state:resolved] http://github.com/railsdog/spree/commit/f859b2eea9940825e53c5af1678...